xhwhis commented on PR #8964: URL: https://github.com/apache/arrow-datafusion/pull/8964#issuecomment-1907325681
> Thanks @xhwhis for your contribution Would you mind adding more details on reason why this change is need, and would be great to cover the change with unit tests You can use `datafusion-cli` to observe the uppercase bug in table alias. ``` DataFusion CLI v34.0.0 ❯ CREATE TABLE IF NOT EXISTS valuetable(c1 INT, c2 VARCHAR) AS VALUES(1,'HELLO'),(12,'DATAFUSION'); 0 rows in set. Query took 0.066 seconds. ❯ SELECT "TEST".c1 from valuetable as "TEST"; Schema error: No field named test.c1. Valid fields are test.c1, test.c2. ``` I believe this PR have a minimal impact. I have added unit tests to cover the changes. Please review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
