paleolimbot commented on code in PR #366:
URL: https://github.com/apache/arrow-nanoarrow/pull/366#discussion_r1465343845
##########
python/src/nanoarrow/schema.py:
##########
@@ -214,18 +255,18 @@ def scale(self) -> int:
return self._c_schema_view.decimal_scale
@property
- def n_children(self) -> int:
+ def n_fields(self) -> int:
Review Comment:
I changed it to maintain the 1:1 mapping between the parameter names (e.g.,
`struct(fields=...)`) and property names. I believe that in pyarrow the term is
"fields" as well (
https://arrow.apache.org/docs/python/generated/pyarrow.ListType.html#pyarrow.ListType.field
).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
