tustvold commented on code in PR #5331:
URL: https://github.com/apache/arrow-rs/pull/5331#discussion_r1465686535
##########
arrow-array/src/builder/generic_list_builder.rs:
##########
@@ -116,6 +116,19 @@ impl<OffsetSize: OffsetSizeTrait, T: ArrayBuilder>
GenericListBuilder<OffsetSize
offsets_builder,
null_buffer_builder: NullBufferBuilder::new(capacity),
values_builder,
+ field: None,
+ }
+ }
+
+ /// Override the field passed to [`GenericListArray::new`]
+ ///
+ /// By default a nullable field is created with the name `item`
+ ///
+ /// Note: [`Self::finish`] and [`Self::finish_cloned`] will panic if the
provided data type does not match `T`
Review Comment:
The ergonomics of this aren't ideal, but aside from adding a `data_type`
method to `ArrayBuilder` I'm not sure of a way around this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
