Re: [I] Port tests in `select.rs` to sqllogictest [arrow-datafusion]

Wed, 24 Jan 2024 18:18:19 -0800 


Tangruilin commented on issue #8213:
URL: 
https://github.com/apache/arrow-datafusion/issues/8213#issuecomment-1909234675

   > Hi both - @Tangruilin seems like we we're working independently on the 
topic 😮 I had raised two PRs previously but seems they remained unnoticed. 
Guess we should try to consolidate into a single PR, feel free to take over 
whatever you're missing currently from #8953 and #8939 and integrate into yours 
if that's ok with you as well.
   > 
   > In #8939 you will find how I implemented the structs.
   > 
   > 
![image](https://private-user-images.githubusercontent.com/10134699/299402375-b907c438-37bd-4b91-a4a3-b5340cceeb13.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDYxNDkzNDIsIm5iZiI6MTcwNjE0OTA0MiwicGF0aCI6Ii8xMDEzNDY5OS8yOTk0MDIzNzUtYjkwN2M0MzgtMzdiZC00YjkxLWE0YTMtYjUzNDBjY2VlYjEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMjUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTI1VDAyMTcyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVjZGFiYmI2OWE0MzZhYzQxNTQ4MGFiZDYwYzZmYmZmM2VkMDljZTAwMjEwODk3MGE5OTc0M2ZjNjI5YjFmNTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.e3Y9Cm0q_KjHjZJo4PNK4-oSb7atWTHgXBKI8LkVYdA)
   
   Maybe We can use my CR?
   Or do you have some suggestions?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to