sgilmore10 commented on PR #39586: URL: https://github.com/apache/arrow/pull/39586#issuecomment-1910677752
> > @sgilmore10 - good catch on noticing the issues in the log. I agree - we should definitely follow up with a PR to enable the `strict` flag. > > This means that all the changes made to the respective files were deleted?? Hi @ShaiviAgarwal2, It just means that when the TestSuite was generated, it excluded the `TestClass`es that had syntax error without issuing a warning or error. This made the MATLAB GitHub Action check pass even though the new tests were not run. By enabling the `strict` flag, the MATLAB GitHub Action check will fail if there are syntax errors in any of the `TestClass`es. Your changes should still be there. I hope this helps. Best, Sarah -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
