alamb commented on code in PR #8996:
URL: https://github.com/apache/arrow-datafusion/pull/8996#discussion_r1466890766
##########
datafusion/core/tests/sql/mod.rs:
##########
@@ -76,79 +76,6 @@ pub mod repartition;
pub mod select;
mod sql_api;
-fn create_left_semi_anti_join_context_with_null_ids(
- column_left: &str,
- column_right: &str,
- repartition_joins: bool,
-) -> Result<SessionContext> {
- let ctx = SessionContext::new_with_config(
- SessionConfig::new()
- .with_repartition_joins(repartition_joins)
- .with_target_partitions(2)
- .with_batch_size(4096),
- );
-
- let t1_schema = Arc::new(Schema::new(vec![
- Field::new(column_left, DataType::UInt32, true),
- Field::new("t1_name", DataType::Utf8, true),
- Field::new("t1_int", DataType::UInt32, true),
- ]));
- let t1_data = RecordBatch::try_new(
- t1_schema,
- vec![
- Arc::new(UInt32Array::from(vec![
- Some(11),
- Some(11),
- Some(22),
- Some(33),
- Some(44),
- None,
- ])),
- Arc::new(StringArray::from(vec![
- Some("a"),
- Some("a"),
- Some("b"),
- Some("c"),
- Some("d"),
- Some("e"),
- ])),
- Arc::new(UInt32Array::from(vec![1, 1, 2, 3, 4, 0])),
- ],
- )?;
- ctx.register_batch("t1", t1_data)?;
-
- let t2_schema = Arc::new(Schema::new(vec![
- Field::new(column_right, DataType::UInt32, true),
- Field::new("t2_name", DataType::Utf8, true),
- Field::new("t2_int", DataType::UInt32, true),
- ]));
- let t2_data = RecordBatch::try_new(
- t2_schema,
- vec![
- Arc::new(UInt32Array::from(vec![
- Some(11),
- Some(11),
- Some(22),
- Some(44),
- Some(55),
- None,
- ])),
- Arc::new(StringArray::from(vec![
- Some("z"),
- Some("z"),
- Some("y"),
- Some("x"),
- Some("w"),
- Some("v"),
- ])),
- Arc::new(UInt32Array::from(vec![3, 3, 1, 3, 3, 0])),
- ],
- )?;
- ctx.register_batch("t2", t2_data)?;
-
- Ok(ctx)
-}
-
async fn register_aggregate_csv_by_sql(ctx: &SessionContext) {
Review Comment:
I agree with the assesment that these tests shouldn't be moved:
https://github.com/apache/arrow-datafusion/issues/8203#issuecomment-1910023057
> The other tests assert the phyical plan, so I do not move them to joins.slt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
