berkaysynnada commented on code in PR #8817:
URL: https://github.com/apache/arrow-datafusion/pull/8817#discussion_r1467280368
##########
datafusion/core/src/physical_optimizer/enforce_sorting.rs:
##########
@@ -812,6 +634,50 @@ mod tests {
let session_ctx = SessionContext::new_with_config(config);
let state = session_ctx.state();
+ // This file has 4 rules that use tree node, apply these rules as
in the
+ // EnforSorting::optimize implementation
+ // After these operations tree nodes should be in a consistent
state.
+ // This code block makes sure that these rules doesn't violate
tree node integrity.
+ {
+ let plan_requirements =
PlanWithCorrespondingSort::new_default($PLAN.clone());
+ let adjusted = plan_requirements
+ .transform_up(&ensure_sorting)
+ .and_then(check_integrity)?;
+ // TODO: End state payloads will be checked here.
Review Comment:
Adding payload checks to each test is time-consuming, and verifying the
accuracy of the results necessitates a separate analysis. I suggest we track
these tasks in a separate ticket as todo, so we don't delay this PR any further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
