tustvold commented on code in PR #5333: URL: https://github.com/apache/arrow-rs/pull/5333#discussion_r1467395175
########## arrow-select/src/take.rs: ########## @@ -769,11 +769,25 @@ to_indices_reinterpret!(Int32Type, UInt32Type); to_indices_identity!(UInt64Type); to_indices_reinterpret!(Int64Type, UInt64Type); +/// Take rows by index from [`RecordBatch`] and returns a new [`RecordBatch`] from those indexes. +pub fn take_record_batch( + record_batch: &RecordBatch, + indices: &[u64], Review Comment: What's the motivation for taking a slice and not an array, as written this will perform an additional copy and doesn't support nulls -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
