alamb commented on code in PR #9013:
URL: https://github.com/apache/arrow-datafusion/pull/9013#discussion_r1468517986


##########
datafusion-cli/src/main.rs:
##########
@@ -136,6 +136,9 @@ struct Args {
         default_value = "40"
     )]
     maxrows: MaxRows,
+
+    #[clap(long, help = "Enables console syntax highlighting")]
+    color: bool,

Review Comment:
   
   
   Another potential option might be to follow the `duckdb` lead and call it 
`ascii`  output mode 🤔 (when there is no color)
   
   ```
   andrewlamb@Andrews-MacBook-Pro:~/Software/influxdb_iox$ duckdb --help
   Usage: duckdb [OPTIONS] FILENAME [SQL]
   FILENAME is the name of an DuckDB database. A new database is created
   if the file does not previously exist.
   OPTIONS include:
      -append              append the database to the end of the file
      -ascii               set output mode to 'ascii'
      -bail                stop after hitting an error
      -batch               force batch I/O
      -box                 set output mode to 'box'
      -column              set output mode to 'column'
      -cmd COMMAND         run "COMMAND" before reading stdin
      -c COMMAND           run "COMMAND" and exit
      -csv                 set output mode to 'csv'
      -echo                print commands before execution
      -init FILENAME       read/process named file
      -[no]header          turn headers on or off
      -help                show this message
      -html                set output mode to HTML
      -interactive         force interactive I/O
      -json                set output mode to 'json'
      -line                set output mode to 'line'
      -list                set output mode to 'list'
      -markdown            set output mode to 'markdown'
      -newline SEP         set output row separator. Default: '\n'
      -nofollow            refuse to open symbolic links to database files
      -no-stdin            exit after processing options instead of reading 
stdin
      -nullvalue TEXT      set text string for NULL values. Default ''
      -quote               set output mode to 'quote'
      -readonly            open the database read-only
      -s COMMAND           run "COMMAND" and exit
      -separator SEP       set output column separator. Default: '|'
      -stats               print memory stats before each finalize
      -table               set output mode to 'table'
      -unsigned            allow loading of unsigned extensions
      -version             show DuckDB version
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to