kmitchener opened a new pull request, #9033:
URL: https://github.com/apache/arrow-datafusion/pull/9033
## Which issue does this PR close?
related to #8844 but doesn't close it
## Rationale for this change
This fixes a lot of the errors related to building without parquet support,
mainly triggered by the datafusion-proto crate. Prior to this PR, you couldn't
run `cargo build -p datafusion-proto --no-default-features` but now you can.
However, `cargo build --no-default-features` still errors when run from the
root of the workspace, but that appears to be due to problems with feature
resolution since `cargo build -p datafusion --no-default-features` still works
as well.
It still leaves warnings when compiling datafusion-proto without parquet
support, but I may follow up on those in another PR. There's a better fix for
those warnings than sprinkling cfg directives around.
## What changes are included in this PR?
- modified the prost build process to insert conditional compilation for
the parquet crate on some message types
- took the opportunity to make more specific includes based on the split
crates rather than just 'datafusion'
- updated the feature dependencies to use the 'dep:' syntax. optional
dependencies still show up as implicit features -- using 'dep:' syntax removes
these implicit features making DataFusion's feature list more intentional.
## Are these changes tested?
existing tests
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
