jayzhan211 commented on code in PR #8946:
URL: https://github.com/apache/arrow-datafusion/pull/8946#discussion_r1469010978
##########
datafusion/physical-expr/src/expressions/get_indexed_field.rs:
##########
@@ -126,7 +138,32 @@ impl GetIndexedFieldExpr {
start: Arc<dyn PhysicalExpr>,
stop: Arc<dyn PhysicalExpr>,
) -> Self {
- Self::new(arg, GetFieldAccessExpr::ListRange { start, stop })
+ Self::new(
+ arg,
+ GetFieldAccessExpr::ListStride {
+ start,
+ stop,
+ stride: Arc::new(Literal::new(ScalarValue::Int64(Some(1))))
+ as Arc<dyn PhysicalExpr>,
+ },
+ )
+ }
+
+ /// Create a new [`GetIndexedFieldExpr`] for accessing the stride
+ pub fn new_stride(
Review Comment:
It is unused in this PR, and I think we might not need it too, since
`new_range` is only used in test, which may be removed in the future since we
can test them in slt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
