westonpace commented on a change in pull request #9095:
URL: https://github.com/apache/arrow/pull/9095#discussion_r565938785
##########
File path: cpp/src/arrow/csv/test_common.cc
##########
@@ -61,5 +61,47 @@ void MakeColumnParser(std::vector<std::string> items,
std::shared_ptr<BlockParse
ASSERT_EQ((*out)->num_rows(), items.size());
}
+const std::vector<std::string> int64_rows = {"123", "4", "-317005557", "",
"N/A", "0"};
+const std::vector<std::string> float_rows = {"0", "123.456", "-3170.55766",
"", "N/A"};
+const std::vector<std::string> decimal128_rows = {"0", "123.456",
"-3170.55766",
+ "", "N/A",
"1233456789.123456789"};
+const std::vector<std::string> iso8601_rows = {"1917-10-17", "2018-09-13",
+ "1941-06-22 04:00", "1945-05-09
09:45:38"};
+const std::vector<std::string> strptime_rows = {"10/17/1917", "9/13/2018",
"9/5/1945"};
+
+static void WriteHeader(std::ostream& writer) {
+ writer << "Int64,Float,Decimal128,ISO8601,Strptime" << std::endl;
+}
+
+static std::string GetCell(std::vector<std::string> base_rows, size_t
row_index) {
Review comment:
I changed to a const-ref
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
