viirya commented on code in PR #8705:
URL: https://github.com/apache/arrow-datafusion/pull/8705#discussion_r1470097227
##########
datafusion/functions/src/encoding/inner.rs:
##########
@@ -32,12 +32,123 @@ use datafusion_expr::ColumnarValue;
use std::sync::Arc;
use std::{fmt, str::FromStr};
+use datafusion_expr::TypeSignature::*;
+use datafusion_expr::{ScalarUDFImpl, Signature, Volatility};
+use std::any::Any;
+
+#[derive(Debug)]
+pub(super) struct EncodeFunc {
+ signature: Signature,
+}
+
+impl EncodeFunc {
+ pub fn new() -> Self {
+ use DataType::*;
+ Self {
+ signature: Signature::one_of(
+ vec![
+ Exact(vec![Utf8, Utf8]),
+ Exact(vec![LargeUtf8, Utf8]),
+ Exact(vec![Binary, Utf8]),
+ Exact(vec![LargeBinary, Utf8]),
+ ],
+ Volatility::Immutable,
+ )
+ }
+ }
+}
+
+impl ScalarUDFImpl for EncodeFunc {
+ fn as_any(&self) -> &dyn Any {
+ self
+ }
+ fn name(&self) -> &str {
+ "encode"
+ }
+
+ fn signature(&self) -> &Signature {
+ &self.signature
+ }
+
+ fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
+ use DataType::*;
+
+ Ok(match arg_types[0] {
+ Utf8 => Utf8,
+ LargeUtf8 => LargeUtf8,
+ Binary => Utf8,
+ LargeBinary => LargeUtf8,
+ Null => Null,
+ _ => {
+ return plan_err!("The encode function can only accept utf8 or
binary.");
+ }
+ })
+ }
+
+ fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
+ encode(args)
+ }
+}
+
+#[derive(Debug)]
+pub(super) struct DecodeFunc {
+ signature: Signature,
+}
+
+impl DecodeFunc {
+ pub fn new() -> Self {
+ use DataType::*;
+ Self {
+ signature: Signature::one_of(
+ vec![
+ Exact(vec![Utf8, Utf8]),
+ Exact(vec![LargeUtf8, Utf8]),
+ Exact(vec![Binary, Utf8]),
+ Exact(vec![LargeBinary, Utf8]),
+ ],
+ Volatility::Immutable,
+ )
+ }
+ }
+}
+impl ScalarUDFImpl for DecodeFunc {
+ fn as_any(&self) -> &dyn Any {
+ self
+ }
+ fn name(&self) -> &str {
+ "decode"
+ }
+
+ fn signature(&self) -> &Signature {
+ &self.signature
+ }
+
+ fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
+ use DataType::*;
+
+ Ok(match arg_types[0] {
+ Utf8 => Binary,
+ LargeUtf8 => LargeBinary,
+ Binary => Binary,
+ LargeBinary => LargeBinary,
+ Null => Null,
+ _ => {
+ return plan_err!("The decode function can only accept utf8 or
binary.");
+ }
+ })
+ }
+
+ fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
+ // Put a feature flag here to make sure this is only compiled when the
feature is activated
Review Comment:
Do we need a TODO here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
