davisusanibar commented on code in PR #39681:
URL: https://github.com/apache/arrow/pull/39681#discussion_r1470131448
##########
java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java:
##########
@@ -332,6 +332,204 @@ public void testSizeOfValueBuffer() {
}
}
+ @Test
+ public void testFixedFloat2() {
+ try (final Float2Vector floatVector = new Float2Vector(EMPTY_SCHEMA_PATH,
allocator)) {
+ boolean error = false;
+ int initialCapacity = 16;
+
+ /* we should not throw exception for these values of capacity */
+ floatVector.setInitialCapacity(MAX_VALUE_COUNT - 1);
+ floatVector.setInitialCapacity(MAX_VALUE_COUNT);
+
+ try {
+ floatVector.setInitialCapacity(MAX_VALUE_COUNT * 4);
+ } catch (OversizedAllocationException oe) {
+ error = true;
+ } finally {
+ assertTrue(error);
+ error = false;
+ }
+
+ floatVector.setInitialCapacity(initialCapacity);
+ /* no memory allocation has happened yet so capacity of underlying
buffer should be 0 */
+ assertEquals(0, floatVector.getValueCapacity());
+
+ /* allocate 32 bytes (16 * 2) */
+ floatVector.allocateNew();
+ /* underlying buffer should be able to store 16 values */
+ assertTrue(floatVector.getValueCapacity() >= initialCapacity);
+ initialCapacity = floatVector.getValueCapacity();
+
+ floatVector.zeroVector();
+
+ /* populate the floatVector */
+ floatVector.set(0, (short) 0x101c); //
Float16.toFloat16(+0.00050163269043f)
+ floatVector.set(2, (short) 0x901c); //
Float16.toFloat16(-0.00050163269043f)
+ floatVector.set(4, (short) 0x101d); //
Float16.toFloat16(+0.000502109527588f)
+ floatVector.set(6, (short) 0x901d); //
Float16.toFloat16(-0.000502109527588f)
+ floatVector.set(8, (short) 0x121c); //
Float16.toFloat16(+0.00074577331543f)
+ floatVector.set(10, (short) 0x921c); //
Float16.toFloat16(-0.00074577331543f)
+ floatVector.set(12, (short) 0x501c); // Float16.toFloat16(+32.875f)
+ floatVector.set(14, (short) 0xd01c); // Float16.toFloat16(-32.875f)
+
+ try {
+ floatVector.set(initialCapacity, (short) 0x141c);
+ } catch (IndexOutOfBoundsException ie) {
+ error = true;
+ } finally {
+ assertTrue(error);
+ error = false;
+ }
+
+ /* check vector contents */
+ assertEquals((short) 0x101c, floatVector.get(0));
+ assertEquals((short) 0x901c, floatVector.get(2));
+ assertEquals((short) 0x101d, floatVector.get(4));
+ assertEquals((short) 0x901d, floatVector.get(6));
+ assertEquals((short) 0x121c, floatVector.get(8));
+ assertEquals((short) 0x921c, floatVector.get(10));
+ assertEquals((short) 0x501c, floatVector.get(12));
+ assertEquals((short) 0xd01c, floatVector.get(14));
+
+ try {
+ floatVector.get(initialCapacity);
+ } catch (IndexOutOfBoundsException ie) {
+ error = true;
+ } finally {
+ assertTrue(error);
+ }
+
+ /* this should trigger a realloc() */
+ floatVector.setSafe(initialCapacity, (short) 0x141c); //
Float16.toFloat16(+0.00100326538086f)
+
+ /* underlying buffer should now be able to store double the number of
values */
+ assertTrue(floatVector.getValueCapacity() >= initialCapacity * 2);
+
+ /* vector data should still be intact after realloc */
+ assertEquals((short) 0x101c, floatVector.get(0));
+ assertEquals((short) 0x901c, floatVector.get(2));
+ assertEquals((short) 0x101d, floatVector.get(4));
+ assertEquals((short) 0x901d, floatVector.get(6));
+ assertEquals((short) 0x121c, floatVector.get(8));
+ assertEquals((short) 0x921c, floatVector.get(10));
+ assertEquals((short) 0x501c, floatVector.get(12));
+ assertEquals((short) 0xd01c, floatVector.get(14));
+ assertEquals((short) 0x141c, floatVector.get(initialCapacity));
+
+ /* reset the vector */
+ int capacityBeforeReset = floatVector.getValueCapacity();
+ floatVector.reset();
+
+ /* capacity shouldn't change after reset */
+ assertEquals(capacityBeforeReset, floatVector.getValueCapacity());
+
+ /* vector data should be zeroed out */
+ for (int i = 0; i < capacityBeforeReset; i++) {
+ assertTrue("non-zero data not expected at index: " + i,
floatVector.isNull(i));
+ }
+ }
+ }
+
+ @Test
+ public void testFixedFloat2WithPossibleTruncate() {
+ try (final Float2Vector floatVector = new Float2Vector(EMPTY_SCHEMA_PATH,
allocator)) {
+ boolean error = false;
+ int initialCapacity = 16;
+
+ /* we should not throw exception for these values of capacity */
+ floatVector.setInitialCapacity(MAX_VALUE_COUNT - 1);
+ floatVector.setInitialCapacity(MAX_VALUE_COUNT);
+
+ try {
+ floatVector.setInitialCapacity(MAX_VALUE_COUNT * 4);
+ } catch (OversizedAllocationException oe) {
+ error = true;
+ } finally {
+ assertTrue(error);
+ error = false;
+ }
+
+ floatVector.setInitialCapacity(initialCapacity);
+ /* no memory allocation has happened yet so capacity of underlying
buffer should be 0 */
+ assertEquals(0, floatVector.getValueCapacity());
+
+ /* allocate 32 bytes (16 * 2) */
+ floatVector.allocateNew();
+ /* underlying buffer should be able to store 16 values */
+ assertTrue(floatVector.getValueCapacity() >= initialCapacity);
+ initialCapacity = floatVector.getValueCapacity();
+
+ floatVector.zeroVector();
+
+ /* populate the floatVector */
+ floatVector.set(0, (short) 0x101c); //
Float16.toFloat16(+0.00050163269043f)
+ floatVector.set(2, (short) 0x901c); //
Float16.toFloat16(-0.00050163269043f)
+ floatVector.set(4, (short) 0x101d); //
Float16.toFloat16(+0.000502109527588f)
+ floatVector.setWithPossibleTruncate(6, 2049.0f); // in f32=2049.000000,
out f16=2048
+ floatVector.setWithPossibleTruncate(8, 4098.0f); // in f32=4098.000000,
out f16=4096
+ floatVector.setWithPossibleTruncate(10, 8196.0f); // in f32=8196.000000,
out f16=8192
+ floatVector.setWithPossibleTruncate(12, 16392.0f); // in
f32=16392.000000, out f16=16384
+ floatVector.setWithPossibleTruncate(14, 32784.0f); // in
f32=32784.000000, out f16=32768
+
+ try {
+ floatVector.setWithPossibleTruncate(initialCapacity, 65519.0f); // in
f32=65519.000000, out f16=65504
+ } catch (IndexOutOfBoundsException ie) {
+ error = true;
+ } finally {
+ assertTrue(error);
+ error = false;
+ }
+
+ /* check vector contents */
+ assertEquals((short) 0x101c, floatVector.get(0));
+ assertEquals((short) 0x901c, floatVector.get(2));
+ assertEquals((short) 0x101d, floatVector.get(4));
+ assertEquals(2048.0f, floatVector.getValueAsFloat(6), 0);
+ assertEquals(4096.0f, floatVector.getValueAsFloat(8), 0);
+ assertEquals(8192.0f, floatVector.getValueAsFloat(10), 0);
+ assertEquals(16384.0f, floatVector.getValueAsFloat(12), 0);
+ assertEquals(32768.0f, floatVector.getValueAsFloat(14), 0);
Review Comment:
Added
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/Float16.java:
##########
@@ -0,0 +1,265 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.arrow.memory.util;
+
+
+import org.apache.arrow.util.VisibleForTesting;
+
+/**
+ * Lifted from Apache Parquet MR project. Ref:
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
