viirya commented on PR #8991: URL: https://github.com/apache/arrow-datafusion/pull/8991#issuecomment-1915736893
> Yeah, but presumably you will have to update the Join operators in DataFusion to take Expressions (rather than `Column`s) and evaluate them on the inputs I think this is already done by this PR. The Join operators in DataFusion actually already evaluate join key expressions (previously they are `Column`s). They are not simply taking the values of columns from input arrays but invoking `evaluate` physical expression API. So once we relax the join key types to general expression, it does what we need, i.e., evaluating the provided join key expressions. It saves me some works to update the operators as you said. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
