mapleFU commented on code in PR #39807:
URL: https://github.com/apache/arrow/pull/39807#discussion_r1471305502
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -397,10 +415,11 @@ class CompressedInputStream::Impl {
std::shared_ptr<InputStream> raw_;
bool is_open_;
std::shared_ptr<Decompressor> decompressor_;
- std::shared_ptr<Buffer> compressed_;
+ std::shared_ptr<ResizableBuffer> compressed_;
// Position in compressed buffer
int64_t compressed_pos_;
std::shared_ptr<ResizableBuffer> decompressed_;
+ std::shared_ptr<ResizableBuffer> decompressed_impl_;
Review Comment:
It's not neccessary to maintain two buffer, I use it here for simplify the
changes(previous impl set `decompressed_ = nullptr` to means decompressed is
consumed). Seems this is not a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
