yyy1000 commented on code in PR #9041:
URL: https://github.com/apache/arrow-datafusion/pull/9041#discussion_r1471465691
##########
datafusion/sql/src/statement.rs:
##########
@@ -718,19 +718,13 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let mut statement_options = StatementOptions::new(options);
let file_format =
statement_options.try_infer_file_type(&statement.target)?;
- let single_file_output =
- statement_options.take_bool_option("single_file_output")?;
Review Comment:
Seems a good idea.
But I worry that some users didn't specify the output folder path using `/`,
but using a
`single_output_option = false`. Keeping this option may let the query
running but has different result. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
