av8or1 commented on PR #39840: URL: https://github.com/apache/arrow/pull/39840#issuecomment-1917586187
OK, I took a look at the two checks that had failures. I didn't see anything in the Python check that applied to my push, but I did find the following in the Dev / Lint: ``` cd /tmp/arrow-lint-p9tofs7a/cpp-build && /usr/local/bin/python /arrow/cpp/build-support/run_cpplint.py --cpplint_binary /arrow/cpp/build-support/cpplint.py --exclude_globs /arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src --source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet /arrow/cpp/src/arrow/filesystem/azurefs.cc:1693: Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3] Done processing /arrow/cpp/src/arrow/filesystem/azurefs.cc Total errors found: 1 /arrow/cpp/src/arrow/filesystem/azurefs_test.cc:1391: Lines should be <= 90 characters long [whitespace/line_length] [2] /arrow/cpp/src/arrow/filesystem/azurefs_test.cc:1399: Lines should be <= 90 characters long [whitespace/line_length] [2] /arrow/cpp/src/arrow/filesystem/azurefs_test.cc:1899: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3] /arrow/cpp/src/arrow/filesystem/azurefs_test.cc:1901: Namespace should be terminated with "// namespace fs" [readability/namespace] [5] /arrow/cpp/src/arrow/filesystem/azurefs_test.cc:61: Failed to find complete declaration of namespace arrow [build/namespaces] [5] Done processing /arrow/cpp/src/arrow/filesystem/azurefs_test.cc Total errors found: 5 ninja: build stopped: subcommand failed. ``` I have made corrections for these and will update. I haven't done that in a Github context, but I'll figure it out. I'll post again when that is successful. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
