alamb opened a new pull request #9347:
URL: https://github.com/apache/arrow/pull/9347


   I was looking at this code yesterday while using it in IOx -- 
https://github.com/influxdata/influxdb_iox/pull/703
   
   ## Rationale:
   Even though `Schema::try_merge` requires a slice of `Schema`s (not schema 
refs) ownership of its inputs,  it copies all of its fields. This is 
inefficient ideal in the common case where most of the fields in the merged 
`Schema` will be the same
   
   ## Changes:
   This PR proposes to change the implementation so that `try_merge` takes 
something  (like a `Vec`) that can iterate over the Schemas passed in and 
consume them, avoiding at least one copy per unique field. I intend no 
algorithmic changes, only performance improvement.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to