lidavidm commented on code in PR #1500:
URL: https://github.com/apache/arrow-adbc/pull/1500#discussion_r1473157145


##########
CONTRIBUTING.md:
##########
@@ -274,6 +274,11 @@ $ cargo test
 
 ## Opening a Pull Request
 
+Before opening a pull request:
+
+1. please check if there is a corresponding issue (_and if not, please make 
one_), and
+2. assign the issue to yourself by commenting "take" in the issue.

Review Comment:
   ```suggestion
   1. Please check if there is a corresponding issue (_and if not, please make 
one_).
   2. Assign the issue to yourself by commenting "take" in the issue.
   3. At the bottom of the PR description, add `Closes #NNNN` where `NNNN` is 
the
      issue number, so that the issue gets linked to your PR properly. ("Fixes"
      and other keywords that GitHub recognizes are also OK, of course.)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to