alamb opened a new pull request, #9087: URL: https://github.com/apache/arrow-datafusion/pull/9087
## Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion/issues/5472 ## Rationale for this change This is something I noticed while working on https://github.com/apache/arrow-datafusion/pull/8849 The count distinct module was getting large so splitting it into smaller modules would makes things easier to navigate ## What changes are included in this PR? 1. Move code to native.rs module (to mirror [strings.rs](https://github.com/apache/arrow-datafusion/blob/main/datafusion/physical-expr/src/aggregate/count_distinct/strings.rs)) 1. rename native to `NativeDistinctCountAccumulator` to `PrimitiveDistinctCountAccumulator` to align with `ArrowPrimitiveType` 2. add some more docs 3. Remove an unecessary typedef ## Are these changes tested? By existing tests ## Are there any user-facing changes? No, this is internal code reorganization. None of this code is accessible outside of the crate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
