alamb commented on code in PR #8902:
URL: https://github.com/apache/arrow-datafusion/pull/8902#discussion_r1473536269
##########
datafusion/common/src/utils.rs:
##########
@@ -497,6 +489,31 @@ pub fn coerced_type_with_base_type_only(
}
}
+pub fn coerced_fixed_size_list_to_list(data_type: &DataType) -> DataType {
Review Comment:
```suggestion
/// Recursively coerce and `FixedSizeList` elements to `List`
pub fn coerced_fixed_size_list_to_list(data_type: &DataType) -> DataType {
```
##########
datafusion/expr/src/signature.rs:
##########
@@ -263,6 +283,33 @@ impl Signature {
volatility,
}
}
+ /// Specialized Signature for ArrayAppend and similar functions
Review Comment:
Nice cleanup
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -77,6 +77,19 @@ AS
FROM arrays
;
+#TODO: create FixedSizeList with NULL column
Review Comment:
Shall we maybe track this TODO with a separate ticket?
##########
datafusion/expr/src/signature.rs:
##########
@@ -116,6 +116,12 @@ pub enum TypeSignature {
/// Function `make_array` takes 0 or more arguments with arbitrary types,
its `TypeSignature`
/// is `OneOf(vec![Any(0), VariadicAny])`.
OneOf(Vec<TypeSignature>),
+ /// Specifies Signatures for array functions
+ ArraySignature(ArrayFunctionSignature),
Review Comment:
I think that is a good change, though a change of the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
