gruuya commented on code in PR #9097:
URL: https://github.com/apache/arrow-datafusion/pull/9097#discussion_r1474069730
##########
datafusion/physical-plan/src/projection.rs:
##########
@@ -56,6 +56,8 @@ pub struct ProjectionExec {
input: Arc<dyn ExecutionPlan>,
/// The output ordering
output_ordering: Option<Vec<PhysicalSortExpr>>,
Review Comment:
In theory this doesn't need to be stored now, since it can be obtained via
`self.equivalence_properties.oeq_class().output_ordering()`, however the last
method has some non-trivial computation which are probably best avoided anytime
there's a call to `ProjectionExec::output_ordering()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
