pitrou commented on issue #39864: URL: https://github.com/apache/arrow/issues/39864#issuecomment-1921307120
> 1. We should add an optional argument "show_metadata" to the ToString method of DataType and other DataType derived class. And we also need to add `show_metadata` to TypeHolder::ToString() , right? Yes! > 2. Default value of `show_metadata` should always be false in derived class. Because virtual functions are dynamically bound, but default parameter values are statically bound. I suppose so, yes. In any case, we want the API to be consistent, this makes life easier for users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
