pitrou commented on code in PR #39772:
URL: https://github.com/apache/arrow/pull/39772#discussion_r1474684817
##########
cpp/src/arrow/array/array_base.h:
##########
@@ -24,6 +24,7 @@
#include <vector>
#include "arrow/array/data.h"
+#include "arrow/array/util.h"
Review Comment:
Is this inclusion still useful?
##########
cpp/src/arrow/array/data.cc:
##########
@@ -140,6 +141,49 @@ std::shared_ptr<ArrayData>
ArrayData::Make(std::shared_ptr<DataType> type, int64
return std::make_shared<ArrayData>(std::move(type), length, null_count,
offset);
}
+namespace {
+template <typename Fn>
+Result<std::shared_ptr<ArrayData>> copy_to_impl(const ArrayData& data,
Review Comment:
Can you address this admittedly minor comment @zeroshade ? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
