alamb commented on code in PR #8988:
URL: https://github.com/apache/arrow-datafusion/pull/8988#discussion_r1475135340
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -704,7 +706,20 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
};
Ok(Expr::ScalarFunction(ScalarFunction::new(fun, args)))
}
-
+ fn sql_position_to_expr(
+ &self,
+ substr_expr: SQLExpr,
+ str_expr: SQLExpr,
+ schema: &DFSchema,
+ planner_context: &mut PlannerContext,
+ ) -> Result<Expr> {
+ let fun = BuiltinScalarFunction::Position;
Review Comment:
> YES, I would do this right now, sorry I have been working on another issue
No rush -- sorry I want to make it clear there is no pressure here. I just
wanted to make sure your PR wasn't waiting on feedback (as I get anxious when
there are so many PRs waiting on review)
Thank you for all your help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
