jp0317 commented on code in PR #39818:
URL: https://github.com/apache/arrow/pull/39818#discussion_r1475461166
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1478,16 +1480,29 @@ class TypedRecordReader : public
TypedColumnReaderImpl<DType>,
// We skipped the levels by incrementing 'levels_position_'. For values
// we do not have a buffer, so we need to read them and throw them away.
// First we need to figure out how many present/not-null values there are.
- std::shared_ptr<::arrow::ResizableBuffer> valid_bits;
- valid_bits = AllocateBuffer(this->pool_);
-
PARQUET_THROW_NOT_OK(valid_bits->Resize(bit_util::BytesForBits(skipped_records),
- /*shrink_to_fit=*/true));
+ int64_t buffer_size = bit_util::BytesForBits(skipped_records);
+ if (valid_bits_for_skip_ == nullptr) {
+ valid_bits_for_skip_ = AllocateBuffer(this->pool_);
+ }
+ if (buffer_size > valid_bits_for_skip_->size()) {
Review Comment:
Thanks for the review. I tried the tests and was not able to get a case with
`skipped_records >=1024`. I may misread the code but it seems the
`skipped_records` [can never exceed
](https://github.com/apache/arrow/blob/main/cpp/src/parquet/column_reader.cc#L1473)
the number of buffered levels. And the number of buffered levels will not
exceed
[kMinLevelBatchSize](https://github.com/apache/arrow/blob/main/cpp/src/parquet/column_reader.cc#L1369).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
