l1nxy commented on PR #5300: URL: https://github.com/apache/arrow-rs/pull/5300#issuecomment-1923324414
@tustvold Hi, I have completed the first version of GCP signed URL generation. Could you please take some time to review it? and then i can update the code gradually. Regarding the credential structure, I think we need to add the client email field. This is because the signed URL generation requires the client email, not just the sign blob method. Even when generating a signed URL with an HMAC key, we still need the client email to create credentials with scope, the code example showed. https://github.com/GoogleCloudPlatform/python-docs-samples/blob/6e591bec774bf0f3bf53864146f24028b98ac8df/storage/signed_urls/generate_signed_urls.py#L63-L65 next, i will add test for the sign blob and add code for using HAMC key to generating signed URL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
