alamb opened a new pull request, #9113: URL: https://github.com/apache/arrow-datafusion/pull/9113
Draft as it - [ ] builds on https://github.com/apache/arrow-datafusion/pull/9075 - [ ] Separate PR for pulling `ColumnarValue::values_to_arrays` and deprecating the old function - [ ] Needs examples for `array_to_string` `expr_fn` in dataframe tests ## Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion/issues/8045 See https://github.com/apache/arrow-datafusion/issues/9100 for discussion ## Rationale for this change We are trying to make DataFusion more modular, and as more array functionality gets added, it is important to be support: 1. users choosing which functionality they want to include in their build and 2. developers to be able to work on the array functions without having to recompile the entire project ## What changes are included in this PR? 1. Make a new `datafusion-functions-array` crate 2. Move `ArrayToString` from `BuiltInScalarFunction` enum and `datafusion-physical-expr` to `datafusion-functions-array`, 3. Add a new feature flag, `array_expressions` If this pattern looks good, I think we can then move the other functions over in a similar way ## Are these changes tested? Yes, by existing and new tests ## Are there any user-facing changes? A new feature flag -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
