r3stl355 commented on PR #9112:
URL:
https://github.com/apache/arrow-datafusion/pull/9112#issuecomment-1925216039
> The
>
> `let array_size = if is_scalar { 1 } else { len.unwrap() };`
>
> variable could now be removed and the for loop could just use len.unwrap()
I think.
Sure, I can do that but `array_size` is also used in the 3 calls to
`to_primitive_array`. Alternatively, I could just move the variable into `else`
as `let array_size = len.unwrap();`. What would be your preference @Omega359 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
