mapleFU commented on code in PR #39908:
URL: https://github.com/apache/arrow/pull/39908#discussion_r1477029042
##########
cpp/src/arrow/compute/expression_test.cc:
##########
@@ -863,6 +863,23 @@ TEST(Expression, ExecuteCall) {
])"));
}
+TEST(Expression, ExecuteCallWithNoArguments) {
+ const int kCount = 10;
+ auto random_options = RandomOptions::FromSeed(/*seed=*/0);
+ ExecBatch input({}, kCount);
+
+ Expression random_expr = call("random", {}, random_options);
+ ASSERT_OK_AND_ASSIGN(random_expr, random_expr.Bind(float64()));
+
+ ASSERT_OK_AND_ASSIGN(Datum actual, ExecuteScalarExpression(random_expr,
input));
+ compute::ExecContext* exec_context = default_exec_context();
+ ASSERT_OK_AND_ASSIGN(auto function,
+ exec_context->func_registry()->GetFunction("random"));
+ ASSERT_OK_AND_ASSIGN(Datum expected,
+ function->Execute(input, &random_options,
exec_context));
+ AssertDatumsEqual(actual, expected, /*verbose=*/true);
Review Comment:
Should we check the output length == 10 explicit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
