comphead commented on code in PR #9110:
URL: https://github.com/apache/arrow-datafusion/pull/9110#discussion_r1477111388
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -5345,19 +5356,41 @@ select array_concat(column1, [7]) from arrays_values_v2;
[7]
# flatten
+# follow DuckDB
+query ?
+select flatten(NULL);
+----
+NULL
+
+# flatten with scalar values #1
query ???
select flatten(make_array(1, 2, 1, 3, 2)),
flatten(make_array([1], [2, 3], [null], make_array(4, null, 5))),
flatten(make_array([[1.1]], [[2.2]], [[3.3], [4.4]]));
----
[1, 2, 1, 3, 2] [1, 2, 3, , 4, , 5] [1.1, 2.2, 3.3, 4.4]
+query ???
+select flatten(arrow_cast(make_array(1, 2, 1, 3, 2), 'LargeList(Int64)')),
+ flatten(arrow_cast(make_array([1], [2, 3], [null], make_array(4, null,
5)), 'LargeList(LargeList(Int64))')),
+ flatten(arrow_cast(make_array([[1.1]], [[2.2]], [[3.3], [4.4]]),
'LargeList(LargeList(LargeList(Float64)))'));
+----
+[1, 2, 1, 3, 2] [1, 2, 3, , 4, , 5] [1.1, 2.2, 3.3, 4.4]
+
+# flatten with with column values
query ????
select column1, column2, column3, column4 from flatten_table;
Review Comment:
I just realized if we need these 2 tests?
```
select column1, column2, column3, column4 from flatten_table;
select column1, column2, column3, column4 from large_flatten_table;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
