ianmcook commented on a change in pull request #9345:
URL: https://github.com/apache/arrow/pull/9345#discussion_r566527458
##########
File path: r/R/table.R
##########
@@ -248,39 +203,9 @@ Table$create <- function(..., schema = NULL) {
}
}
-#' @export
-as.data.frame.Table <- function(x, row.names = NULL, optional = FALSE, ...) {
- df <- Table__to_dataframe(x, use_threads = option_use_threads())
- if (!is.null(r_metadata <- x$metadata$r)) {
- df <- apply_arrow_r_metadata(df, .unserialize_arrow_r_metadata(r_metadata))
- }
- df
-}
-
-#' @export
-as.list.Table <- as.list.RecordBatch
-
-#' @export
-row.names.Table <- row.names.RecordBatch
-
-#' @export
-dimnames.Table <- dimnames.RecordBatch
-
-#' @export
-dim.Table <- function(x) c(x$num_rows, x$num_columns)
-
#' @export
names.Table <- function(x) x$ColumnNames()
-#' @export
-`names<-.Table` <- function(x, value) x$RenameColumns(value)
-
-#' @export
-`[.Table` <- `[.RecordBatch`
-
-#' @export
-`[[.Table` <- `[[.RecordBatch`
-
#' @export
`[[<-.Table` <- function(x, i, value) {
Review comment:
Could you add a TODO/comment here describing why this have not yet been
changed to be methods of the base class `ArrowTabular`? And another one where
`$<-.Table` is defined
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
