mmaitre314 commented on issue #3279: URL: https://github.com/apache/arrow-rs/issues/3279#issuecomment-1926015789
Looking into whether I could tackle that issue, based on #4891 is the current thinking around applying regexes to the output of the Thrift Rust code generator because it may not be maintained anymore? It seems that either updating the code generator or its output should work. The trade-off is likely difficulty to get an updated version of the code generator with a fix out vs regex replacement being brittle. In the code generator, this seems to be the line with an issue ([t_rs_generator.cc](https://github.com/apache/thrift/blob/75cf93ed22264fecaa79e82f05fa9f02d49fc58b/compiler/cpp/src/thrift/generate/t_rs_generator.cc#L1846)): ``` f_gen_ << indent() << "Ok(ret.expect(\"return value should have been constructed\"))" << endl; ``` which becomes in [format.rs](https://github.com/apache/arrow-rs/blob/master/parquet/src/format.rs) (8 instances according to GitHub [search](https://github.com/search?q=repo%3Aapache%2Farrow-rs+%22return+value+should+have+been+constructed%22+path%3A**%2Fformat.rs&type=code)): ``` Ok(ret.expect("return value should have been constructed")) ``` I see a few more calls to `.expect()` in format.rs but I am not sure whether those are true program-logic errors or could be hit when decoding corrupted Parquet files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
