raulcd commented on code in PR #39762:
URL: https://github.com/apache/arrow/pull/39762#discussion_r1478042873
##########
dev/release/post-08-docs.sh:
##########
@@ -84,6 +84,18 @@ if [ "$is_major_release" = "yes" ] ; then
previous_series=${previous_version%.*}
mv docs_temp docs/${previous_series}
fi
+# Update DOCUMENTATION_OPTIONS.theme_switcher_version_match and
Review Comment:
I would keep doing a single commit for updating the documentation and
another for the banner, in case a review is necessary is much easier to do.
```suggestion
git add docs
git commit -m "[Website] Update documentations for ${version}"
# Update DOCUMENTATION_OPTIONS.theme_switcher_version_match and
```
##########
dev/release/post-08-docs.sh:
##########
@@ -84,6 +84,18 @@ if [ "$is_major_release" = "yes" ] ; then
previous_series=${previous_version%.*}
mv docs_temp docs/${previous_series}
fi
+# Update DOCUMENTATION_OPTIONS.theme_switcher_version_match and
+# DOCUMENTATION_OPTIONS.show_version_warning_banner
+pushd docs/${previous_version}
Review Comment:
This is `previous_series` as we move the old docs to `14.0` instead of
`14.0.0`
```suggestion
pushd docs/${previous_series}
```
##########
dev/release/post-08-docs.sh:
##########
@@ -84,6 +84,18 @@ if [ "$is_major_release" = "yes" ] ; then
previous_series=${previous_version%.*}
mv docs_temp docs/${previous_series}
fi
+# Update DOCUMENTATION_OPTIONS.theme_switcher_version_match and
+# DOCUMENTATION_OPTIONS.show_version_warning_banner
+pushd docs/${previous_version}
+find ./ \
+ -type f \
+ -exec \
+ sed -i.bak \
+ -e "s/DOCUMENTATION_OPTIONS.theme_switcher_version_match =
'';/DOCUMENTATION_OPTIONS.theme_switcher_version_match =
'${previous_version}';/g" \
+ -e "s/DOCUMENTATION_OPTIONS.show_version_warning_banner =
false/DOCUMENTATION_OPTIONS.show_version_warning_banner = true/g" \
+ {} \;
+find ./ -name '*.bak' -delete
+popd
git add docs
git commit -m "[Website] Update documentations for ${version}"
Review Comment:
```suggestion
git add docs/${previous_series}
git commit -m "[Website] Update warning banner for ${previous_series}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
