zeroshade commented on code in PR #39913:
URL: https://github.com/apache/arrow/pull/39913#discussion_r1478426763
##########
go/arrow/flight/flightsql/client.go:
##########
@@ -450,6 +450,31 @@ func (c *Client) PrepareSubstrait(ctx context.Context,
plan SubstraitPlan, opts
return parsePreparedStatementResponse(c, c.Alloc, stream)
}
+func (c *Client) LoadPreparedStatementFromResult(result
*pb.ActionCreatePreparedStatementResult) (*PreparedStatement, error) {
Review Comment:
rather than exposing the `pb.ActionCreatePreparedStatementResult` directly,
please add a type for it in `types.go` with the other protobuf aliasing we do
instead. We try to avoid using the protobuf types *directly* in the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
