alamb commented on code in PR #9075:
URL: https://github.com/apache/arrow-datafusion/pull/9075#discussion_r1479736114
##########
datafusion/execution/src/registry.rs:
##########
@@ -45,7 +48,26 @@ pub trait FunctionRegistry {
not_impl_err!("Registering ScalarUDF")
}
- // TODO add register_udaf and register_udwf
+ /// Registers a new [`AggregateUDF`], returning any previously registered
+ /// implementation.
+ ///
+ /// Returns an error (the default) if the function can not be registered,
+ /// for example if the registry is read only.
+ fn register_udaf(
Review Comment:
I think it is backwards compatible because it provides a default
implementation (to return a Not Yet Implemented error)
Thus, any existing implementations of `FunctionRegistry` will continue to
compile and work as they did before, without any required code changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
