Omega359 commented on code in PR #9137: URL: https://github.com/apache/arrow-datafusion/pull/9137#discussion_r1480333453
########## datafusion-examples/examples/regexp.rs: ########## @@ -0,0 +1,300 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// Review Comment: When I started with DataFusion it was the examples that gave me the initial base to work from - especially since this projects was essentially my first time with Rust code. I personally think having both dataframe and SQL examples for the same thing to be quite helpful for those getting started who are not already I was actually thinking of spending some time (when I had it) to enhance the scalar docs to add examples where missing and to add whole new sections to the examples as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
