Dandandan commented on a change in pull request #9364:
URL: https://github.com/apache/arrow/pull/9364#discussion_r567063657
##########
File path: rust/datafusion/src/sql/planner.rs
##########
@@ -421,16 +415,85 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
// The SELECT expressions, with wildcards expanded.
let select_exprs = self.prepare_select_exprs(&plan,
&select.projection)?;
+ // Optionally the HAVING expression.
+ let having_expr_opt = if let Some(having_expr) = &select.having {
Review comment:
This probably could use `Option::map` instead of `if let`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
