pitrou commented on code in PR #39888:
URL: https://github.com/apache/arrow/pull/39888#discussion_r1482644992
##########
cpp/src/arrow/testing/gtest_util.cc:
##########
@@ -238,7 +238,7 @@ std::string ToStringWithMetadata(const T& t, bool
show_metadata) {
}
std::string ToStringWithMetadata(const DataType& t, bool show_metadata) {
- return t.ToString();
+ return t.ToString(show_metadata);
}
Review Comment:
Thanks, but this can actually be simplified now. `ToStringWithMetadata` was
created because `DataType::ToString` didn't support the `show_metadata`
argument. Now that it does, `ToStringWithMetadata` can probably be suppressed
and all calls to `ToStringWithMetadata(t, show_metadata)` replaced with
`t.ToString(show_metadata)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
