alamb commented on issue #9100: URL: https://github.com/apache/arrow-datafusion/issues/9100#issuecomment-1933850627
@Omega359 asked a good question on https://github.com/apache/arrow-datafusion/pull/8705#issuecomment-1932661075 that I wanted to not get lost in comments on a merged pull request > * Where should public rustdocs for the function go? I think they should go in the `datafusion-functions` crate which is then both re-exported by the main datafusion crate: <img width="1064" alt="Screenshot 2024-02-08 at 6 05 00 AM" src="https://github.com/apache/arrow-datafusion/assets/490673/80a4e392-ee73-409a-a386-2abe38bdcc57";> Following the model of the existing `expr_fn`s the `encode` and `decode` functions were re-exported in `datafusion::prelude` as well: <img width="1078" alt="Screenshot 2024-02-08 at 6 06 33 AM" src="https://github.com/apache/arrow-datafusion/assets/490673/814cdf02-a48b-4b30-bfad-482cfb3d48d4";> > * Benchmarks? Tests && test data? Is that all going to live at functions/benches and functions/tests ? I think we should do this if/when possible -- benchmarks that depend on `SessionContext` for example probably need to stay in datafusion/core but otherwise we should move them to datafusion-functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
