jorisvandenbossche commented on issue #39991: URL: https://github.com/apache/arrow/issues/39991#issuecomment-1933937168
I am personally in favor of keeping the current name, for the reasons I mentioned in the linked thread. The `to_numpy()` method is an existing method on all pyarrow Arrays, and from which you expect to get a 1D numpy array of the same length as the pyarrow array. I certainly agree that the 2D array is more useful for a FixedSizeTensorArray, but changing `to_numpy()` to a 2D array just for this class would break consistency with all other types. (e.g. generally I expect `pa.array(arr.to_numpy())` to work (not necessarily preserving the exact type because of limitations of numpy notwithstanding), but that would no longer be the case when we change the return value for FixedSizeTensorArray) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
