paleolimbot commented on code in PR #39977:
URL: https://github.com/apache/arrow/pull/39977#discussion_r1482864452
##########
python/pyarrow/types.pxi:
##########
@@ -114,7 +123,14 @@ cdef void* _as_c_pointer(v, allow_null=False) except *:
"Arrow library", UserWarning, stacklevel=2)
c_ptr = <void*> <uintptr_t > v
elif PyCapsule_CheckExact(v):
- c_ptr = PyCapsule_GetPointer(v, NULL)
+ capsule_name = PyCapsule_GetName(v)
+ if capsule_name == NULL or strcmp(capsule_name, "r_extptr") == 0:
Review Comment:
In C that would always return false (because it would compare memory
addresses and not string content). I would be surprised if Cython overrode
that? Probably `bytes(capsule_name) == "r_extptr"` would work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
