viirya commented on code in PR #9163:
URL: https://github.com/apache/arrow-datafusion/pull/9163#discussion_r1483114234
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -1209,7 +1209,14 @@ impl SMJStream {
) {
// The reverse of the selection mask. For the rows not
pass join filter above,
// we need to join them (left or right) with null rows
for outer joins.
- let not_mask = compute::not(mask)?;
+ let not_mask = if mask.null_count() > 0 {
Review Comment:
I re-checked the results in `sort_merge_join.slt` and it should be correct
(as it is same as `join.slt` which is produced by hash join operator).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
