bkietz commented on code in PR #39067:
URL: https://github.com/apache/arrow/pull/39067#discussion_r1483115211
##########
cpp/src/arrow/filesystem/filesystem.h:
##########
@@ -156,7 +163,11 @@ struct IterationTraits<fs::FileInfoVector> {
namespace fs {
/// \brief Abstract file system API
-class ARROW_EXPORT FileSystem : public
std::enable_shared_from_this<FileSystem> {
+class ARROW_EXPORT FileSystem
+ /// \cond false
+ : public std::enable_shared_from_this<FileSystem>
+/// \endcond
+{ // NOLINT
public:
virtual ~FileSystem();
Review Comment:
After all filesystems are hidden behind FileSystemFromUri, it might be
desirable to supplement or replace `type_name()` with a member which returns a
URI scheme that corresponds to the factory used to create the instance. Taking
this a step further, we could also add full round tripping of filesystems
through URI strings. Both of these seem potentially useful for interactive use
cases where a user might receive a filesystem and want to know how it was
constructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
