zeroshade commented on code in PR #39980:
URL: https://github.com/apache/arrow/pull/39980#discussion_r1483182043
##########
python/pyarrow/tests/test_cffi.py:
##########
@@ -652,3 +652,64 @@ def test_export_import_device_array():
# Now released
with assert_schema_released:
pa.Array._import_from_c(ptr_array, ptr_schema)
+
+
+@needs_cffi
+def test_export_import_device_batch():
+ c_schema = ffi.new("struct ArrowSchema*")
+ ptr_schema = int(ffi.cast("uintptr_t", c_schema))
+ c_array = ffi.new("struct ArrowDeviceArray*")
+ ptr_array = int(ffi.cast("uintptr_t", c_array))
+
+ gc.collect() # Make sure no Arrow data dangles in a ref cycle
+ old_allocated = pa.total_allocated_bytes()
+
+ # Schema is known up front
+ batch = make_batch()
+ schema = batch.schema
+ py_value = batch.to_pydict()
+ batch._export_to_c_device(ptr_array)
+ assert pa.total_allocated_bytes() > old_allocated
+
+ # verify exported struct
+ assert c_array.device_type == 1 # ARROW_DEVICE_CPU 1
+ assert c_array.device_id == -1
+ assert c_array.array.length == 2
Review Comment:
could we add a test that uses the arrow cuda lib and verify the device etc.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
