ericphanson commented on code in PR #498:
URL: https://github.com/apache/arrow-julia/pull/498#discussion_r1483550076
##########
src/arraytypes/struct.jl:
##########
@@ -77,16 +77,19 @@ struct ToStruct{T,i,A} <: AbstractVector{T}
data::A # eltype is NamedTuple or some struct
end
-ToStruct(x::A, j::Integer) where {A} =
- ToStruct{fieldtype(Base.nonmissingtype(eltype(A)), j),j,A}(x)
+function ToStruct(x::A, j::Integer, hasmissing::Bool=false) where {A}
+ AT = fieldtype(eltype(A), j)
Review Comment:
do we still want `Base.nonmissingtype(eltype(A))` inside the field type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
