tshauck commented on PR #9175: URL: https://github.com/apache/arrow-datafusion/pull/9175#issuecomment-1936790641
Thanks @alamb -- certainly down to add a test. Before I go the route you mentioned, I wanted to ask if you knew that would follow the stream decoding path? Looking at https://github.com/apache/arrow-datafusion/blob/ae882356171513c9d6c22b3bd966898fb4e8cac0/datafusion/core/src/datasource/physical_plan/csv.rs#L393-L441 in the CsvOpener, I think local files would result in `.convert_read` being called and not `.convert_stream` which is what is modified in this PR? Is that right? If not I'll code that up, otherwise perhaps adding a specific unittest that calls `.convert_stream` or maybe there's a way to force `.convert_stream` to be called from the slt-based tests? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
