peter-toth commented on PR #8891: URL: https://github.com/apache/arrow-datafusion/pull/8891#issuecomment-1936946457
@berkaysynnada, I was thinking about `Jump` a bit today, and actually it was surprisingly easy to extend the current `Skip` functionality to match the suggested in bottom-up traversals too. I'm still not sure if `Jump` will ever be used in any bottom-up closures, but it does no harm. 😉 In https://github.com/apache/arrow-datafusion/pull/8891/commits/dcf0189f3de0b1754a1c934df82fb6ec393bb9aa I only modified the `transform`/`rewrite` beaviour that depend on `Transformed` and `TreeNode::map_children()` so the `apply`/ `visit`, that uses the `handle_tree_recursion` macro, is yet to be fixed. But, as far as I see from the proposal and the discussion above you would like to unify the base of all APIs (which seems doable as `TreeNode::map_children()` is capable to replace `TreeNode::apply_children()` after this PR), so I would leave that part to you if you don't mind. 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
