alamb commented on code in PR #8827:
URL: https://github.com/apache/arrow-datafusion/pull/8827#discussion_r1479137719
##########
datafusion/physical-expr/src/aggregate/count_distinct/strings.rs:
##########
@@ -92,403 +86,3 @@ impl<O: OffsetSizeTrait> Accumulator for
StringDistinctCountAccumulator<O> {
std::mem::size_of_val(self) + self.0.size()
}
}
-
-/// Maximum size of a string that can be inlined in the hash table
Review Comment:
This code and tests were moved into `string_map.rs` and made general
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
